Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: dart/utils/apidoc/apidoc.gyp

Issue 13722007: Fix dependencies of apidoc. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Add comment Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/utils/apidoc/apidoc.gyp
diff --git a/dart/utils/apidoc/apidoc.gyp b/dart/utils/apidoc/apidoc.gyp
index f3f484a45e344b4e619cb781d9e934287502f1bd..df2e4c5c9173c95f14d5b41fc5fdbfcd6a004451 100644
--- a/dart/utils/apidoc/apidoc.gyp
+++ b/dart/utils/apidoc/apidoc.gyp
@@ -28,19 +28,45 @@
'actions': [
{
'action_name': 'run_apidoc',
+ # The 'inputs' list records the files whose timestamps are
+ # compared to the files listed in 'outputs'. If a file
+ # 'outputs' doesn't exist or if a file in 'inputs' is newer
+ # than a file in 'outputs', this action is executed. Notice
+ # that the dependencies listed above has nothing to do with
+ # when this action is executed. You must list a file in
+ # 'inputs' to make sure that it exists before the action is
+ # executed, or to make sure this action is re-run.
+ #
+ # We want to build the platform documentation whenever
+ # dartdoc, apidoc, or its dependency changes. This prevents
+ # people from accidentally breaking apidoc when making
+ # changes to the platform libraries and or when modifying
+ # dart2js or the VM.
+ #
+ # In addition, we want to make sure that the platform
+ # documentation is regenerated when the platform sources
+ # changes.
+ #
+ # So we want this action to be re-run when a dart file
+ # changes in this directory, or in the SDK library (we may
+ # no longer need to list the files in ../../runtime/lib and
+ # ../../runtime/bin, as most of them has moved to
+ # ../../sdk/lib).
+ #
+ # In addition, we want to make sure the documentation is
+ # regenerated when a resource file (CSS, PNG, etc) is
+ # updated. This is because these files are also copied to
+ # the output directory.
'inputs': [
'<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)',
'<(PRODUCT_DIR)/dart2js.snapshot',
'<!@(["python", "../../tools/list_files.py", "\\.(css|ico|js|json|png|sh|txt|yaml|py)$", ".", "../../sdk/lib/_internal/dartdoc"])',
- '<!@(["python", "../../tools/list_files.py", "\\.dart$", "../../sdk/lib", "../../runtime/lib", "../../runtime/bin"])',
+ '<!@(["python", "../../tools/list_files.py", "\\.dart$", ".", "../../sdk/lib", "../../runtime/lib", "../../runtime/bin"])',
'../../sdk/bin/dart',
'../../sdk/bin/dart.bat',
'../../sdk/bin/dart2js',
'../../sdk/bin/dart2js.bat',
],
- 'inputs': [
- '<!@(["python", "../../tools/list_files.py", "\\.(css|png|dart)$", "."])',
- ],
'outputs': [
'<(PRODUCT_DIR)/api_docs/index.html',
'<(PRODUCT_DIR)/api_docs/client-static.js',
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698