Issue 1370833002: Remove ElementLocator.locateWithOffset altogether.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370833002: Remove ElementLocator.locateWithOffset altogether. (Closed)

Created:
5 years, 2 months ago by scheglov

Modified:
5 years, 2 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove ElementLocator.locateWithOffset altogether. It was needed only for the old Angular implementation support, which overlayed its own Element subclasses into normal Dart AST, for example for string literals - names of components. As we don't support this anymore, there is no need for the method. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/3924b15d85f120b2e5214a8a5347b5f80a88ab8d

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -37 lines)			Patch
M	pkg/analysis_server/lib/src/analysis_server.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	pkg/analysis_server/lib/src/computer/computer_hover.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/edit/edit_domain.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/ast.dart	View	1 chunk	+0 lines, -19 lines	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest_test.dart	View	1 chunk	+0 lines, -13 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scheglov

5 years, 2 months ago (2015-09-25 21:57:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3924b15d85f120b2e5214a8a5347b5f80a88ab8d (presubmit successful).

Expand Messages | Collapse Messages