Issue 1370553002: Make output of Dart_TimelineGetTrace consumable by mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1370553002: Make output of Dart_TimelineGetTrace consumable by mojo (Closed)

Created:
5 years, 3 months ago by Cutch

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Make output of Dart_TimelineGetTrace consumable by mojo - Mojo TraceCollector expects a comma separated stream of event maps. Adjust the output of Dart_TimelineGetTrace to match that. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/037deed29da28878610fdf9e420b8bf76f5c160f

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+58 lines, -18 lines)			Patch
M	runtime/vm/dart_api_impl.cc	View	1 2	6 chunks	+32 lines, -15 lines	0 comments	Download
M	runtime/vm/timeline.h	View		4 chunks	+4 lines, -3 lines	0 comments	Download
M	runtime/vm/timeline.cc	View		3 chunks	+22 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Cutch

5 years, 3 months ago (2015-09-24 20:25:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
037deed29da28878610fdf9e420b8bf76f5c160f (presubmit successful).