Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1042)

Unified Diff: runtime/vm/timeline.h

Issue 1370553002: Make output of Dart_TimelineGetTrace consumable by mojo (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/timeline.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/timeline.h
diff --git a/runtime/vm/timeline.h b/runtime/vm/timeline.h
index 9ca76b979aecd188083d8c366d7840fde7397ee0..669652b47790543976a6e535001bffd39246eecd 100644
--- a/runtime/vm/timeline.h
+++ b/runtime/vm/timeline.h
@@ -490,6 +490,7 @@ class TimelineEventRecorder {
// Interface method(s) which must be implemented.
virtual void PrintJSON(JSONStream* js, TimelineEventFilter* filter) = 0;
+ virtual void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter) = 0;
int64_t GetNextAsyncId();
@@ -536,6 +537,7 @@ class TimelineEventRingRecorder : public TimelineEventRecorder {
~TimelineEventRingRecorder();
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
+ void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
protected:
TimelineEvent* StartEvent();
@@ -560,6 +562,7 @@ class TimelineEventStreamingRecorder : public TimelineEventRecorder {
~TimelineEventStreamingRecorder();
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
+ void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
// Called when |event| is ready to be streamed. It is unsafe to keep a
// reference to |event| as it may be freed as soon as this function returns.
@@ -584,10 +587,8 @@ class TimelineEventEndlessRecorder : public TimelineEventRecorder {
public:
TimelineEventEndlessRecorder();
- // NOTE: Calling this while threads are filling in their blocks is not safe
- // and there are no checks in place to ensure that doesn't happen.
- // TODO(koda): Add isolate count to |ThreadRegistry| and verify that it is 1.
void PrintJSON(JSONStream* js, TimelineEventFilter* filter);
+ void PrintTraceEvent(JSONStream* js, TimelineEventFilter* filter);
protected:
TimelineEvent* StartEvent();
« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/timeline.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698