Issue 13704004: dart2js: Use js('source') instead of js['source'] to invoke JS mini-parser

Issue 13704004: dart2js: Use js('source') instead of js['source'] to invoke JS mini-parser (Closed)

Created:
7 years, 8 months ago by erikcorry

Modified:
7 years, 8 months ago

Reviewers:
ahe, sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart2js: Use js('source') instead of js['source'] to invoke JS mini-parser R=ahe@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=21021

Patch Set 2 : Go back to js.if_ instead of jsBuilder.if_ #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+226 lines, -235 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js/builder.dart	View	1	2 chunks	+2 lines, -12 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart	View	1	59 chunks	+193 lines, -193 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/emitter_no_eval.dart	View	1	4 chunks	+13 lines, -13 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_backend/native_emitter.dart	View	1	8 chunks	+13 lines, -13 lines	0 comments	Download
M	tests/compiler/dart2js/class_codegen_test.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/js_parser_test.dart	View		2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

ahe

lgtm https://codereview.chromium.org/13704004/diff/1/sdk/lib/_internal/compiler/implementation/js/builder.dart File sdk/lib/_internal/compiler/implementation/js/builder.dart (right): https://codereview.chromium.org/13704004/diff/1/sdk/lib/_internal/compiler/implementation/js/builder.dart#newcode10 sdk/lib/_internal/compiler/implementation/js/builder.dart:10: Expression js(String source) { You could also have ...

7 years, 8 months ago (2013-04-05 13:47:20 UTC) #2

sra1

Why are we making this change? It seems strictly worse to have to write jsBuiler.fun, ...

7 years, 8 months ago (2013-04-05 15:04:09 UTC) #3

erikcorry

7 years, 8 months ago (2013-04-06 10:52:38 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r21021 (presubmit successful).

Expand Messages | Collapse Messages