sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart - Issue 13704004: dart2js: Use js('source') instead of js['source'] to invoke JS mini-parser

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

Issue 13704004: dart2js: Use js('source') instead of js['source'] to invoke JS mini-parser (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Go back to js.if_ instead of jsBuilder.if_ Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/js/builder.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

index 2597d91a131c5911b21cbdc13885b5a6e55860ac..c981c709d2c0cfc464f6cd29d93fd907273f98e0 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/constant_emitter.dart

@@ -93,7 +93,7 @@ class ConstantReferenceEmitter implements ConstantVisitor<jsAst.Expression> {

jsAst.Expression visitTrue(TrueConstant constant) {

if (compiler.enableMinification) {

// Use !0 for true.

- return js["!0"];

+ return js("!0");

} else {

return new jsAst.LiteralBool(true);

}

@@ -102,7 +102,7 @@ class ConstantReferenceEmitter implements ConstantVisitor<jsAst.Expression> {

jsAst.Expression visitFalse(FalseConstant constant) {

if (compiler.enableMinification) {

// Use !1 for false.

- return js["!1"];

+ return js("!1");

} else {

return new jsAst.LiteralBool(false);

}