Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(651)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1368173002: Do not eagerly finalize when optimizing. Remove allocation of temporary strings in new space. (Closed)

Created:
5 years, 2 months ago by srdjan
Modified:
5 years, 2 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not eagerly finalize when optimizing. Remove allocation of temporary strings in new space. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/98340f7d9ef0e3bee39ce49a3e63d1f055aca289

Patch Set 1 #

Patch Set 2 : "Cleanup" #

Total comments: 4

Patch Set 3 : Improve comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -29 lines) Patch
M runtime/vm/class_finalizer.cc View 1 2 1 chunk +4 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_optimizer.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/object.h View 1 3 chunks +8 lines, -3 lines 0 comments Download
M runtime/vm/object.cc View 1 7 chunks +27 lines, -11 lines 0 comments Download
M runtime/vm/report.cc View 1 1 chunk +25 lines, -13 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
srdjan
5 years, 2 months ago (2015-09-25 20:37:46 UTC) #2
regis
lgtm, but the comments could be clearer. https://codereview.chromium.org/1368173002/diff/20001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/1368173002/diff/20001/runtime/vm/class_finalizer.cc#newcode849 runtime/vm/class_finalizer.cc:849: // seems ...
5 years, 2 months ago (2015-09-25 20:55:24 UTC) #3
srdjan
https://codereview.chromium.org/1368173002/diff/20001/runtime/vm/class_finalizer.cc File runtime/vm/class_finalizer.cc (right): https://codereview.chromium.org/1368173002/diff/20001/runtime/vm/class_finalizer.cc#newcode849 runtime/vm/class_finalizer.cc:849: // seems OK to allocate temporary type in old ...
5 years, 2 months ago (2015-09-25 21:15:59 UTC) #4
srdjan
5 years, 2 months ago (2015-09-25 21:31:20 UTC) #5
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
98340f7d9ef0e3bee39ce49a3e63d1f055aca289 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698