Do not eagerly finalize when optimizing. Remove allocation of temporary strings in new space.

runtime/vm/report.cc

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/report.h"
 
 #include "vm/code_patcher.h"
 #include "vm/exceptions.h"
 #include "vm/flags.h"
 #include "vm/longjump.h"
@@ skipping 28 matching lines @@
   }
   String& result = String::Handle();
   if (!script.IsNull()) {
     const String& script_url = String::Handle(script.url());
     if (token_pos >= 0) {
       intptr_t line, column;
       script.GetTokenLocation(token_pos, &line, &column);
       // Only report the line position if we have the original source. We still
       // need to get a valid column so that we can report the ^ mark below the
       // snippet.
+      // Allocate formatted strings in old sapce as they may be created during
+      // optimizing compilation. Those strings are created rarely and should not
+      // polute old space.
       if (script.HasSource()) {
-        result = String::NewFormatted("'%s': %s: line %" Pd " pos %" Pd ": ",
+        result = String::NewFormatted(Heap::kOld,
+                                      "'%s': %s: line %" Pd " pos %" Pd ": ",
                                       script_url.ToCString(),
                                       message_header,
                                       line,
                                       column);
       } else {
-        result = String::NewFormatted("'%s': %s: line %" Pd ": ",
+        result = String::NewFormatted(Heap::kOld,
+                                      "'%s': %s: line %" Pd ": ",
                                       script_url.ToCString(),
                                       message_header,
                                       line);
       }
       // Append the formatted error or warning message.
-      result = String::Concat(result, message);
+      GrowableHandlePtrArray<const String> strs(Thread::Current()->zone(), 5);
+      strs.Add(result);
+      strs.Add(message);
       // Append the source line.
-      const String& script_line = String::Handle(script.GetLine(line));
+      const String& script_line = String::Handle(
+          script.GetLine(line, Heap::kOld));
       ASSERT(!script_line.IsNull());
-      result = String::Concat(result, Symbols::NewLine());
-      result = String::Concat(result, script_line);
-      result = String::Concat(result, Symbols::NewLine());
+      strs.Add(Symbols::NewLine());
+      strs.Add(script_line);
+      strs.Add(Symbols::NewLine());
       // Append the column marker.
       const String& column_line = String::Handle(
-          String::NewFormatted("%*s\n", static_cast<int>(column), "^"));
-      result = String::Concat(result, column_line);
+          String::NewFormatted(Heap::kOld,
+                               "%*s\n", static_cast<int>(column), "^"));
+      strs.Add(column_line);
+      // TODO(srdjan): Use Strings::FromConcatAll in old space, once
+      // implemented.
+      result = Symbols::FromConcatAll(strs);
     } else {
       // Token position is unknown.
-      result = String::NewFormatted("'%s': %s: ",
+      result = String::NewFormatted(Heap::kOld, "'%s': %s: ",
                                     script_url.ToCString(),
                                     message_header);
-      result = String::Concat(result, message);
+      result = String::Concat(result, message, Heap::kOld);
     }
   } else {
     // Script is unknown.
     // Append the formatted error or warning message.
-    result = String::NewFormatted("%s: ", message_header);
-    result = String::Concat(result, message);
+    result = String::NewFormatted(Heap::kOld, "%s: ", message_header);
+    result = String::Concat(result, message, Heap::kOld);
   }
   return result.raw();
 }
 
 
 void Report::LongJump(const Error& error) {
   Thread::Current()->long_jump_base()->Jump(1, error);
   UNREACHABLE();
 }
 
@@ skipping 145 matching lines @@
     trace_warning.AddProperty("type", "JSCompatibilityWarning");
     trace_warning.AddProperty("script", script);
     trace_warning.AddProperty("tokenPos", token_pos);
     trace_warning.AddProperty("message", message);
   }
   trace_buffer->Trace(micros, js.ToCString(), true);  // Already escaped.
 }
 
 }  // namespace dart