Issue 1367973002: VM: Initialize Instruction objects with break instructions instead of null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1367973002: VM: Initialize Instruction objects with break instructions instead of null. (Closed)

Created:
5 years, 3 months ago by Florian Schneider

Modified:
5 years, 2 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

VM: Initialize Instruction objects with break instructions instead of null. On ia32 this is int3(). This also makes precompiled instruction snapshots deterministic (to be precise the empty space due to alignment), and not depending on the address of the null object at snapshot creation time. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/9fa3d7c9e4e2c407ada1eb7fe2c235029404f508

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+87 lines, -56 lines)			Patch
M	runtime/vm/assembler_arm.h	View		2 chunks	+53 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_arm.cc	View		2 chunks	+1 line, -46 lines	0 comments	Download
M	runtime/vm/assembler_arm64.h	View	1	2 chunks	+10 lines, -3 lines	0 comments	Download
M	runtime/vm/assembler_ia32.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_mips.h	View	1	1 chunk	+13 lines, -4 lines	0 comments	Download
M	runtime/vm/assembler_x64.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

5 years, 2 months ago (2015-09-25 12:10:38 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
9fa3d7c9e4e2c407ada1eb7fe2c235029404f508 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages