runtime/vm/assembler_ia32.h - Issue 1367973002: VM: Initialize Instruction objects with break instructions instead of null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/assembler_ia32.h

Issue 1367973002: VM: Initialize Instruction objects with break instructions instead of null. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/assembler_ia32.h

diff --git a/runtime/vm/assembler_ia32.h b/runtime/vm/assembler_ia32.h

index 44ba10ef3c0dbbfde092641afb8ed863dba18feb..c391612890ca3499daf9e3e78f1b0e34f3f9fe59 100644

--- a/runtime/vm/assembler_ia32.h

+++ b/runtime/vm/assembler_ia32.h

@@ -632,6 +632,10 @@ class Assembler : public ValueObject {

void int3();

void hlt();

+ static uword GetBreakInstructionFiller() {

+ return 0xCCCCCCCC;

+ }

// Note: verified_mem mode forces far jumps.

void j(Condition condition, Label* label, bool near = kFarJump);

void j(Condition condition, const ExternalLabel* label);

« no previous file with comments | « runtime/vm/assembler_arm64.h ('k') | runtime/vm/assembler_mips.h » ('j') | no next file with comments »