Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136753012: Refactor unboxed fields in preparation of reusable SIMD boxes (Closed)

Created:
6 years, 10 months ago by Cutch
Modified:
6 years, 10 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Refactor unboxed fields code in preparation of reusable SIMD boxes. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=32199

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : \ #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Patch Set 8 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+312 lines, -94 lines) Patch
M runtime/vm/intermediate_language.h View 1 2 3 4 5 6 7 2 chunks +2 lines, -8 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 2 3 4 5 6 7 2 chunks +31 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 3 4 5 6 7 9 chunks +69 lines, -20 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 2 3 4 5 6 7 9 chunks +64 lines, -19 lines 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 2 3 4 5 6 7 8 chunks +60 lines, -18 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 2 3 4 5 6 7 9 chunks +67 lines, -20 lines 0 comments Download
M runtime/vm/object.h View 1 2 3 4 5 6 7 1 chunk +6 lines, -9 lines 0 comments Download
M runtime/vm/object.cc View 1 2 3 4 5 6 7 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Cutch
6 years, 10 months ago (2014-01-30 23:45:20 UTC) #1
srdjan
https://codereview.chromium.org/136753012/diff/80008/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/136753012/diff/80008/runtime/vm/intermediate_language_arm.cc#newcode1586 runtime/vm/intermediate_language_arm.cc:1586: explicit StoreInstanceFieldSlowPath(const Class& cls, Remove explicit. I would put ...
6 years, 10 months ago (2014-01-30 23:58:39 UTC) #2
Cutch
https://codereview.chromium.org/136753012/diff/80008/runtime/vm/intermediate_language_arm.cc File runtime/vm/intermediate_language_arm.cc (right): https://codereview.chromium.org/136753012/diff/80008/runtime/vm/intermediate_language_arm.cc#newcode1586 runtime/vm/intermediate_language_arm.cc:1586: explicit StoreInstanceFieldSlowPath(const Class& cls, On 2014/01/30 23:58:39, srdjan wrote: ...
6 years, 10 months ago (2014-01-31 00:18:49 UTC) #3
Florian Schneider
Lgtm.
6 years, 10 months ago (2014-01-31 10:24:41 UTC) #4
Cutch
6 years, 10 months ago (2014-01-31 16:45:31 UTC) #5
Message was sent while issue was closed. 
Committed patchset #8 manually as r32199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698