Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(715)

Unified Diff: runtime/vm/object.h

Issue 136753012: Refactor unboxed fields in preparation of reusable SIMD boxes (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index eaa5b725c250b0cdf4372e4b6e75a572ef437aab..eccf39fcdfcf2a37a690e0aa1511873a78c1edfe 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -2187,17 +2187,14 @@ class Field : public Object {
return r;
}
- bool IsUnboxedField() const {
- return is_unboxing_candidate()
- && !is_final()
- && (guarded_cid() == kDoubleCid && !is_nullable());
+ intptr_t UnboxedFieldCid() const {
+ ASSERT(IsUnboxedField());
+ return guarded_cid();
}
- bool IsPotentialUnboxedField() const {
- return is_unboxing_candidate()
- && (IsUnboxedField() ||
- (!is_final() && (guarded_cid() == kIllegalCid)));
- }
+ bool IsUnboxedField() const;
+
+ bool IsPotentialUnboxedField() const;
bool is_unboxing_candidate() const {
return UnboxingCandidateBit::decode(raw_ptr()->kind_bits_);
« no previous file with comments | « runtime/vm/intermediate_language_x64.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698