Issue 13674004: Wrapping files without library tags is neither necessary nor correct anymore.

Issue 13674004: Wrapping files without library tags is neither necessary nor correct anymore. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org, ricow1, floitsch, Anton Muhin

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Wrapping files without library tags is neither necessary nor correct anymore. Committed: https://code.google.com/p/dart/source/detail?r=20971

Patch Set 2 : Merged and address comments #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -47 lines)			Patch
M	dart/tests/compiler/dart2js_extra/dart2js_extra.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	dart/tests/lib/lib.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	dart/tests/utils/utils.status	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	dart/tools/testing/dart/browser_test.dart	View		1 chunk	+0 lines, -6 lines	0 comments	Download
M	dart/tools/testing/dart/test_suite.dart	View	1	7 chunks	+2 lines, -34 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/13674004/diff/1/dart/tests/utils/utils.status File dart/tests/utils/utils.status (left): https://codereview.chromium.org/13674004/diff/1/dart/tests/utils/utils.status#oldcode15 dart/tests/utils/utils.status:15: dart2js_test: Fail # http://dartbug.com/2264 Would be nice if ...

7 years, 8 months ago (2013-04-05 15:00:19 UTC) #2

ahe

Thank you, Martin! https://codereview.chromium.org/13674004/diff/1/dart/tests/utils/utils.status File dart/tests/utils/utils.status (left): https://codereview.chromium.org/13674004/diff/1/dart/tests/utils/utils.status#oldcode15 dart/tests/utils/utils.status:15: dart2js_test: Fail # http://dartbug.com/2264 On 2013/04/05 ...

7 years, 8 months ago (2013-04-05 15:08:55 UTC) #3

ahe

7 years, 8 months ago (2013-04-05 15:11:54 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20971 (presubmit successful).

Expand Messages | Collapse Messages