dart/tools/testing/dart/browser_test.dart - Issue 13674004: Wrapping files without library tags is neither necessary nor correct anymore.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/tools/testing/dart/browser_test.dart

Issue 13674004: Wrapping files without library tags is neither necessary nor correct anymore. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Merged and address comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/tools/testing/dart/browser_test.dart

diff --git a/dart/tools/testing/dart/browser_test.dart b/dart/tools/testing/dart/browser_test.dart

index 5e7c7152bb88c13c09d0d6966298588f12e6ee93..cb8fd7de14a7cc30c26ec9ed26db5733eba66cd6 100644

--- a/dart/tools/testing/dart/browser_test.dart

+++ b/dart/tools/testing/dart/browser_test.dart

@@ -49,12 +49,6 @@ String getHtmlLayoutContents(String scriptType, String sourceScript) =>

</html>

""";

-String wrapDartTestInLibrary(Path testRelativeToDart) =>

-"""

-library libraryWrapper;

-part '/$testRelativeToDart';

-""";

String dartTestWrapper(bool usePackageImport, String libraryPathComponent) {

// Tests inside "pkg" import unittest using "package:". All others use a

// relative path. The imports need to agree, so use a matching form here.

« no previous file with comments | « dart/tests/utils/utils.status ('k') | dart/tools/testing/dart/test_suite.dart » ('j') | no next file with comments »