Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 1365403002: Do not suggest static fields in constructor initializer - fixes #24256 (Closed)

Created:
5 years, 2 months ago by danrubel
Modified:
5 years, 2 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not suggest static fields in constructor initializer - fixes #24256 R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/6cd9e0da71636e1908171679f95a4b43052ca81d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 2 months ago (2015-09-25 21:03:16 UTC) #2
scheglov
LGTM
5 years, 2 months ago (2015-09-25 21:25:49 UTC) #3
danrubel
5 years, 2 months ago (2015-09-26 09:59:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6cd9e0da71636e1908171679f95a4b43052ca81d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698