Do not suggest static fields in constructor initializer - fixes #24256

pkg/analysis_server/lib/src/services/completion/prefixed_element_contributor.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library services.completion.contributor.dart.invocation;
 
 import 'dart:async';
 
 import 'package:analysis_server/src/services/completion/dart_completion_manager.dart';
 import 'package:analysis_server/src/services/completion/local_declaration_visitor.dart';
@@ skipping 109 matching lines @@
                 referencedFields.add(fieldName);
               }
             }
           }
         }
 
         // Add suggestions for fields that are not already referenced
         ClassDeclaration classDecl =
             constructorDecl.getAncestor((p) => p is ClassDeclaration);
         for (ClassMember member in classDecl.members) {
-          if (member is FieldDeclaration) {
+          if (member is FieldDeclaration && !member.isStatic) {
             for (VariableDeclaration varDecl in member.fields.variables) {
               SimpleIdentifier fieldId = varDecl.name;
               if (fieldId != null) {
                 String fieldName = fieldId.name;
                 if (fieldName != null && fieldName.length > 0) {
                   if (!referencedFields.contains(fieldName)) {
                     CompletionSuggestion suggestion =
                         createFieldSuggestion(request.source, member, varDecl);
                     if (suggestion != null) {
                       request.addSuggestion(suggestion);
@@ skipping 292 matching lines @@
     }
     return new Future.value(false);
   }
 
   @override
   Future<bool> visitVariableElement(VariableElement element) {
     InterfaceTypeSuggestionBuilder.suggestionsFor(request, element.type);
     return new Future.value(true);
   }
 }