Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1361423004: Don't use a special var descriptor for :async_op since it can now be either stack or context alloca… (Closed)

Created:
5 years, 2 months ago by rmacnak
Modified:
5 years, 2 months ago
CC:
reviews_dartlang.org, turnidge, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't use a special var descriptor for :async_op since it can now be either stack or context allocated. BUG=http://dartbug.com/24439 R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/d7b46bf5c1a0f1287a41435bf1856c994054a836

Patch Set 1 #

Patch Set 2 : also assert async op is either closure or null #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -78 lines) Patch
A + runtime/observatory/tests/service/step_into_async_no_await_test.dart View 1 chunk +12 lines, -22 lines 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 1 chunk +12 lines, -4 lines 0 comments Download
M runtime/vm/compiler.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M runtime/vm/debugger.cc View 1 4 chunks +21 lines, -13 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +0 lines, -5 lines 2 comments Download
M runtime/vm/raw_object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/scopes.cc View 4 chunks +13 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
rmacnak
5 years, 2 months ago (2015-09-25 20:24:21 UTC) #2
regis
lgtm
5 years, 2 months ago (2015-09-25 20:36:10 UTC) #3
rmacnak
Committed patchset #2 (id:20001) manually as d7b46bf5c1a0f1287a41435bf1856c994054a836 (presubmit successful).
5 years, 2 months ago (2015-09-25 20:47:45 UTC) #4
Florian Schneider
5 years, 2 months ago (2015-09-28 10:58:05 UTC) #6
Message was sent while issue was closed. 
dbc:

https://codereview.chromium.org/1361423004/diff/20001/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://codereview.chromium.org/1361423004/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:11459: static const char* VarKindString(int kind) {
s/VarKindString/LocalVarDescriptors::KindToString/g

https://codereview.chromium.org/1361423004/diff/20001/runtime/vm/object.cc#ne...
runtime/vm/object.cc:11579: const char* LocalVarDescriptors::KindToStr(intptr_t
kind) {
s/intptr_t kind/RawLocalVarDescriptors::VarInfoKind kind/

Powered by Google App Engine
This is Rietveld 408576698