Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: runtime/vm/object.cc

Issue 1361423004: Don't use a special var descriptor for :async_op since it can now be either stack or context alloca… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: also assert async op is either closure or null Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/object.h" 5 #include "vm/object.h"
6 6
7 #include "include/dart_api.h" 7 #include "include/dart_api.h"
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/assembler.h" 9 #include "vm/assembler.h"
10 #include "vm/cpu.h" 10 #include "vm/cpu.h"
(...skipping 11438 matching lines...) Expand 10 before | Expand all | Expand 10 after
11449 } 11449 }
11450 11450
11451 11451
11452 void LocalVarDescriptors::GetInfo(intptr_t var_index, 11452 void LocalVarDescriptors::GetInfo(intptr_t var_index,
11453 RawLocalVarDescriptors::VarInfo* info) const { 11453 RawLocalVarDescriptors::VarInfo* info) const {
11454 ASSERT(var_index < Length()); 11454 ASSERT(var_index < Length());
11455 *info = raw()->data()[var_index]; 11455 *info = raw()->data()[var_index];
11456 } 11456 }
11457 11457
11458 11458
11459 static const char* VarKindString(int kind) { 11459 static const char* VarKindString(int kind) {
Florian Schneider 2015/09/28 10:58:05 s/VarKindString/LocalVarDescriptors::KindToString/
11460 switch (kind) { 11460 switch (kind) {
11461 case RawLocalVarDescriptors::kStackVar: 11461 case RawLocalVarDescriptors::kStackVar:
11462 return "StackVar"; 11462 return "StackVar";
11463 break; 11463 break;
11464 case RawLocalVarDescriptors::kContextVar: 11464 case RawLocalVarDescriptors::kContextVar:
11465 return "ContextVar"; 11465 return "ContextVar";
11466 break; 11466 break;
11467 case RawLocalVarDescriptors::kContextLevel: 11467 case RawLocalVarDescriptors::kContextLevel:
11468 return "ContextLevel"; 11468 return "ContextLevel";
11469 break; 11469 break;
11470 case RawLocalVarDescriptors::kSavedCurrentContext: 11470 case RawLocalVarDescriptors::kSavedCurrentContext:
11471 return "CurrentCtx"; 11471 return "CurrentCtx";
11472 break; 11472 break;
11473 case RawLocalVarDescriptors::kAsyncOperation:
11474 return "AsyncOperation";
11475 break;
11476 default: 11473 default:
11477 UNREACHABLE(); 11474 UNREACHABLE();
11478 return "Unknown"; 11475 return "Unknown";
11479 } 11476 }
11480 } 11477 }
11481 11478
11482 11479
11483 static int PrintVarInfo(char* buffer, int len, 11480 static int PrintVarInfo(char* buffer, int len,
11484 intptr_t i, 11481 intptr_t i,
11485 const String& var_name, 11482 const String& var_name,
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
11572 var.AddProperty("name", var_name.ToCString()); 11569 var.AddProperty("name", var_name.ToCString());
11573 var.AddProperty("index", static_cast<intptr_t>(info.index())); 11570 var.AddProperty("index", static_cast<intptr_t>(info.index()));
11574 var.AddProperty("beginPos", static_cast<intptr_t>(info.begin_pos)); 11571 var.AddProperty("beginPos", static_cast<intptr_t>(info.begin_pos));
11575 var.AddProperty("endPos", static_cast<intptr_t>(info.end_pos)); 11572 var.AddProperty("endPos", static_cast<intptr_t>(info.end_pos));
11576 var.AddProperty("scopeId", static_cast<intptr_t>(info.scope_id)); 11573 var.AddProperty("scopeId", static_cast<intptr_t>(info.scope_id));
11577 var.AddProperty("kind", KindToStr(info.kind())); 11574 var.AddProperty("kind", KindToStr(info.kind()));
11578 } 11575 }
11579 } 11576 }
11580 11577
11581 11578
11582 const char* LocalVarDescriptors::KindToStr(intptr_t kind) { 11579 const char* LocalVarDescriptors::KindToStr(intptr_t kind) {
Florian Schneider 2015/09/28 10:58:05 s/intptr_t kind/RawLocalVarDescriptors::VarInfoKin
11583 switch (kind) { 11580 switch (kind) {
11584 case RawLocalVarDescriptors::kStackVar: 11581 case RawLocalVarDescriptors::kStackVar:
11585 return "StackVar"; 11582 return "StackVar";
11586 case RawLocalVarDescriptors::kContextVar: 11583 case RawLocalVarDescriptors::kContextVar:
11587 return "ContextVar"; 11584 return "ContextVar";
11588 case RawLocalVarDescriptors::kContextLevel: 11585 case RawLocalVarDescriptors::kContextLevel:
11589 return "ContextLevel"; 11586 return "ContextLevel";
11590 case RawLocalVarDescriptors::kSavedCurrentContext: 11587 case RawLocalVarDescriptors::kSavedCurrentContext:
11591 return "SavedCurrentContext"; 11588 return "SavedCurrentContext";
11592 case RawLocalVarDescriptors::kAsyncOperation:
11593 return "AsyncOperation";
11594 default: 11589 default:
11595 UNIMPLEMENTED(); 11590 UNIMPLEMENTED();
11596 return NULL; 11591 return NULL;
11597 } 11592 }
11598 } 11593 }
11599 11594
11600 RawLocalVarDescriptors* LocalVarDescriptors::New(intptr_t num_variables) { 11595 RawLocalVarDescriptors* LocalVarDescriptors::New(intptr_t num_variables) {
11601 ASSERT(Object::var_descriptors_class() != Class::null()); 11596 ASSERT(Object::var_descriptors_class() != Class::null());
11602 if (num_variables < 0 || num_variables > kMaxElements) { 11597 if (num_variables < 0 || num_variables > kMaxElements) {
11603 // This should be caught before we reach here. 11598 // This should be caught before we reach here.
(...skipping 9847 matching lines...) Expand 10 before | Expand all | Expand 10 after
21451 return tag_label.ToCString(); 21446 return tag_label.ToCString();
21452 } 21447 }
21453 21448
21454 21449
21455 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const { 21450 void UserTag::PrintJSONImpl(JSONStream* stream, bool ref) const {
21456 Instance::PrintJSONImpl(stream, ref); 21451 Instance::PrintJSONImpl(stream, ref);
21457 } 21452 }
21458 21453
21459 21454
21460 } // namespace dart 21455 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/raw_object.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698