Get rid of LocalTest.tearDown.

Get rid of LocalTest.tearDown.

We can express this purely in the Declarer, which makes the LocalTest
and Invoker APIs cleaner.

R=kevmoo@google.com, rnystrom@google.com

Committed: https://github.com/dart-lang/test/commit/a19a3b5c455820f731fb44c5db78222c53d1c3c4

[nweiz, 2015-09-24 00:58:10]

nweiz@google.com changed reviewers:
+ rnystrom@google.com

[kevmoo, 2015-09-24 07:02:59]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2015-09-24 07:03:00]

lgtm

[Bob Nystrom, 2015-09-24 16:05:02]

lgtm

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/declarer.dart
File lib/src/backend/declarer.dart (right):

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/declarer.da...
lib/src/backend/declarer.dart:50: }).then((_) => group.runTearDown());
Should this be whenComplete() or are errors already handled before we get here?

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/invoker.dart
File lib/src/backend/invoker.dart (right):

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/invoker.dar...
lib/src/backend/invoker.dart:148: /// completes returned future. It does not
remove any outstanding callbacks
"and the completes returned future" no has grammar.

https://codereview.chromium.org/1361303002/diff/1/test/backend/declarer_test....
File test/backend/declarer_test.dart (right):

https://codereview.chromium.org/1361303002/diff/1/test/backend/declarer_test....
test/backend/declarer_test.dart:113: _declarer.test("description 1",
expectAsync(() {
Can you just make this function async and use a regular throw?

If the intent is specifically to make an unreturned future to ensure the zone
catches it, leave a comment to that effect.

[nweiz, 2015-09-24 19:54:15]

Code review changes

[nweiz, 2015-09-24 19:55:42]

Committed patchset #2 (id:20001) manually as
a19a3b5c455820f731fb44c5db78222c53d1c3c4 (presubmit successful).

[nweiz, 2015-09-24 19:56:20]

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/declarer.dart
File lib/src/backend/declarer.dart (right):

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/declarer.da...
lib/src/backend/declarer.dart:50: }).then((_) => group.runTearDown());
On 2015/09/24 16:05:02, Bob Nystrom wrote:
> Should this be whenComplete() or are errors already handled before we get
here?

waitForOutstandingCallbacks has a zone error handler, so it won't ever throw.

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/invoker.dart
File lib/src/backend/invoker.dart (right):

https://codereview.chromium.org/1361303002/diff/1/lib/src/backend/invoker.dar...
lib/src/backend/invoker.dart:148: /// completes returned future. It does not
remove any outstanding callbacks
On 2015/09/24 16:05:02, Bob Nystrom wrote:
> "and the completes returned future" no has grammar.

Done.

https://codereview.chromium.org/1361303002/diff/1/test/backend/declarer_test....
File test/backend/declarer_test.dart (right):

https://codereview.chromium.org/1361303002/diff/1/test/backend/declarer_test....
test/backend/declarer_test.dart:113: _declarer.test("description 1",
expectAsync(() {
On 2015/09/24 16:05:02, Bob Nystrom wrote:
> Can you just make this function async and use a regular throw?
> 
> If the intent is specifically to make an unreturned future to ensure the zone
> catches it, leave a comment to that effect.

Done.