Issue 1360053003: Fix some cases where Map.containsValue did not accept Object as argument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1360053003: Fix some cases where Map.containsValue did not accept Object as argument. (Closed)

Created:
5 years, 3 months ago by Lasse Reichstein Nielsen

Modified:
5 years, 3 months ago

Reviewers:
wibling

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix some cases where Map.containsValue did not accept Object as argument. Add tests. Also remove a left-over check in SplayTreeMap. BUG= https://github.com/dart-lang/dev_compiler/issues/344 R=wibling@google.com Committed: https://github.com/dart-lang/sdk/commit/4e94938f7ef2fb6443f6fafc7dd7a16111622059

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -15 lines)			Patch
M	sdk/lib/_internal/js_runtime/lib/constant_map.dart	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/collection/maps.dart	View	2 chunks	+5 lines, -5 lines	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/corelib/map_test.dart	View	1 chunk	+21 lines, -7 lines	0 comments	Download

Total messages: 4 (1 generated)

Lasse Reichstein Nielsen

5 years, 3 months ago (2015-09-23 09:27:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e94938f7ef2fb6443f6fafc7dd7a16111622059 (presubmit successful).