Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(973)

Unified Diff: sdk/lib/_internal/js_runtime/lib/constant_map.dart

Issue 1360053003: Fix some cases where Map.containsValue did not accept Object as argument. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sdk/lib/collection/maps.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/js_runtime/lib/constant_map.dart
diff --git a/sdk/lib/_internal/js_runtime/lib/constant_map.dart b/sdk/lib/_internal/js_runtime/lib/constant_map.dart
index 8f813fc6615d2ae952c3d12eabe2ebafccf2f834..8a6a5c9d930370a3151b5d52ea9fd7058a6cbd1d 100644
--- a/sdk/lib/_internal/js_runtime/lib/constant_map.dart
+++ b/sdk/lib/_internal/js_runtime/lib/constant_map.dart
@@ -75,7 +75,7 @@ class ConstantStringMap<K, V> extends ConstantMap<K, V> {
final _jsObject;
final List<K> _keys;
- bool containsValue(V needle) {
+ bool containsValue(Object needle) {
return values.any((V value) => value == needle);
}
@@ -160,7 +160,7 @@ class GeneralConstantMap<K, V> extends ConstantMap<K, V> {
return backingMap;
}
- bool containsValue(V needle) {
+ bool containsValue(Object needle) {
return _getMap().containsValue(needle);
}
« no previous file with comments | « no previous file | sdk/lib/collection/maps.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698