Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 13597004: Synced basic_debugger_test start on new "debugger initialized" message. (Closed)

Created:
7 years, 8 months ago by Tom Ball
Modified:
7 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Synced basic_debugger_test start on new "debugger initialized" message. Committed: https://code.google.com/p/dart/source/detail?r=20997

Patch Set 1 #

Patch Set 2 : fixed indention #

Patch Set 3 : added comment #

Total comments: 6

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -18 lines) Patch
M runtime/bin/main.cc View 1 2 3 5 chunks +12 lines, -2 lines 0 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 2 3 4 6 chunks +12 lines, -15 lines 0 comments Download
M tests/standalone/standalone.status View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Tom Ball
7 years, 8 months ago (2013-04-04 22:44:37 UTC) #1
hausner
LGTM. https://codereview.chromium.org/13597004/diff/3001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/13597004/diff/3001/runtime/vm/debugger.cc#newcode1580 runtime/vm/debugger.cc:1580: OS::Print("Debugger initialized\n"); I think the handshake should even ...
7 years, 8 months ago (2013-04-04 23:17:45 UTC) #2
Tom Ball
https://codereview.chromium.org/13597004/diff/3001/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/13597004/diff/3001/runtime/vm/debugger.cc#newcode1580 runtime/vm/debugger.cc:1580: OS::Print("Debugger initialized\n"); On 2013/04/04 23:17:45, hausner wrote: > I ...
7 years, 8 months ago (2013-04-04 23:24:56 UTC) #3
devoncarew
lgtm As an fyi, when we start up a VM process from the editor, we ...
7 years, 8 months ago (2013-04-05 00:48:23 UTC) #4
kustermann
lgtm - and thanks a lot for fixing this. Since we have only one test ...
7 years, 8 months ago (2013-04-05 08:20:08 UTC) #5
Tom Ball
Committed patchset #5 manually as r20997 (presubmit successful).
7 years, 8 months ago (2013-04-05 20:55:15 UTC) #6
Tom Ball
7 years, 8 months ago (2013-04-05 21:28:52 UTC) #7
Message was sent while issue was closed.
I had to leave basic_debugger_test disabled, since Florian broke it separately
with a bad expect import change (issue 9703). I changed its "skip" to "pass
fail" as you suggested, however.

https://codereview.chromium.org/13597004/diff/3001/tests/standalone/debugger/...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/13597004/diff/3001/tests/standalone/debugger/...
tests/standalone/debugger/debug_lib.dart:306: }
On 2013/04/05 08:20:08, kustermann wrote:
> I'd actually test if 'line == "Debugger initialized"' -- in case somebody else
> adds another OS::Print statement which is executed earlier, we could end up
> calling 'openConnection' before the debuggee is ready.

Done.

> Additionally, I think it wouldn't hurt if we print the "Debugger initialized"
> message (as we do with all other stdout/stderr lines).

It was being displayed twice, because a debugger is initialized for each
isolate. I moved the initialized message to main.cc, and removed this test.

https://codereview.chromium.org/13597004/diff/3001/tests/standalone/debugger/...
tests/standalone/debugger/debug_lib.dart:448: print("Error while connecting to
debugee: $asyncErr");
On 2013/04/05 08:20:08, kustermann wrote:
> Would be nice if you could change that from
>   print("Error while connecting to debugee: $asyncErr");
> to
>   error("Error while connecting to debugee: $asyncErr");
> otherwise the test will be reported as passing even if it couldn't connect to
> the debuggee.

Done.

Powered by Google App Engine
This is Rietveld 408576698