Synced basic_debugger_test start on new "debugger initialized" message.

runtime/vm/debugger.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/debugger.h"
 
 #include "include/dart_api.h"
 
 #include "vm/code_generator.h"
 #include "vm/code_patcher.h"
@@ skipping 1558 matching lines @@
   isolate_ = isolate;
   // Create a port here, we don't expect to receive any messages on this port.
   // This port will be used as a unique ID to represet the isolate in the
   // debugger wire protocol messages.
   // NOTE: SetLive is never called on this port.
   isolate_id_ = PortMap::CreatePort(isolate->message_handler());
   initialized_ = true;
 
   // Signal isolate creation event.
   SignalIsolateEvent(Debugger::kIsolateCreated);
+  if (FLAG_verbose_debug) {
+    OS::Print("Debugger initialized\n");

[hausner, 2013/04/04 23:17:45]

I think the handshake should even work without this message, since there is
stdout output when the debugger reaches the breakpoint at the beginning of
main().

[Tom Ball, 2013/04/04 23:24:56]

I tried removing it and the test hangs. You're right that once the test starts
running then stdout messages are printed, but the race condition we're facing is
that the test starts running before the debuggee is ready.

+  }
 }
 
 
 void Debugger::NotifyCompilation(const Function& func) {
   if (src_breakpoints_ == NULL) {
     // Return with minimal overhead if there are no breakpoints.
     return;
   }
   Function& lookup_function = Function::Handle(func.raw());
   if (func.IsImplicitClosureFunction()) {
@@ skipping 152 matching lines @@
 }
 
 
 void Debugger::RegisterCodeBreakpoint(CodeBreakpoint* bpt) {
   ASSERT(bpt->next() == NULL);
   bpt->set_next(code_breakpoints_);
   code_breakpoints_ = bpt;
 }
 
 }  // namespace dart