Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 1359503002: Spec says empty namedArguments is const {}, not const <Symbol, dynamic>{}. (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
gbracha
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Spec says empty namedArguments is const {}, not const <Symbol, dynamic>{}. BUG=http://dartbug.com/24331 R=gbracha@google.com Committed: https://github.com/dart-lang/sdk/commit/5ee2da4475e17afd2459716dc86168884a45327a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -1 line) Patch
M runtime/lib/invocation_mirror_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/language/invocation_mirror_empty_arguments_test.dart View 1 chunk +46 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 3 months ago (2015-09-18 23:58:09 UTC) #2
gbracha
lgtm
5 years, 3 months ago (2015-09-19 00:02:37 UTC) #3
rmacnak
5 years, 3 months ago (2015-09-19 00:05:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5ee2da4475e17afd2459716dc86168884a45327a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698