runtime/lib/invocation_mirror_patch.dart - Issue 1359503002: Spec says empty namedArguments is const {}, not const <Symbol, dynamic>{}.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/invocation_mirror_patch.dart

Issue 1359503002: Spec says empty namedArguments is const {}, not const <Symbol, dynamic>{}. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/invocation_mirror_patch.dart

diff --git a/runtime/lib/invocation_mirror_patch.dart b/runtime/lib/invocation_mirror_patch.dart

index cc820cbb0a27dd7c52375d5961a948588bb1ac93..09b68270f27c99cdc9b7eddd803bf8968b84cfd7 100644

--- a/runtime/lib/invocation_mirror_patch.dart

+++ b/runtime/lib/invocation_mirror_patch.dart

@@ -80,7 +80,7 @@ class _InvocationMirror implements Invocation {

int numPositionalArguments = _argumentsDescriptor[1] - 1;

int numNamedArguments = numArguments - numPositionalArguments;

if (numNamedArguments == 0) {

- return _namedArguments = const <Symbol, dynamic>{};

+ return _namedArguments = const {};

}

_namedArguments = new Map<Symbol, dynamic>();

for (int i = 0; i < numNamedArguments; i++) {

« no previous file with comments | « no previous file | tests/language/invocation_mirror_empty_arguments_test.dart » ('j') | no next file with comments »