Issue 1359023002: Extract Dart specific node management into DartUnitIndexObjectManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1359023002: Extract Dart specific node management into DartUnitIndexObjectManager. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Extract Dart specific node management into DartUnitIndexObjectManager. We want to be able to index not just CompilationUnitElement(s), but also for example results of Angular resolution, which while are based on resolved CompilationUnit(s), are not ready together with it, so should live in separate split index nodes. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/531f1d1e5bb94f02cbed35fecc4d32c0ec1428d7

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+407 lines, -336 lines)			Patch
M	pkg/analysis_server/lib/src/services/index/index_contributor.dart	View	3 chunks	+19 lines, -18 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/index_store.dart	View	1 chunk	+9 lines, -30 lines	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/local_index.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/analysis_server/lib/src/services/index/store/split_store.dart	View	10 chunks	+304 lines, -198 lines	1 comment	Download
M	pkg/analysis_server/test/services/index/dart_index_contributor_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analysis_server/test/services/index/store/split_store_test.dart	View	22 chunks	+71 lines, -88 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1359023002/diff/1/pkg/analysis_server/lib/src/services/index/store/split_store.dart File pkg/analysis_server/lib/src/services/index/store/split_store.dart (right): https://codereview.chromium.org/1359023002/diff/1/pkg/analysis_server/lib/src/services/index/store/split_store.dart#newcode43 pkg/analysis_server/lib/src/services/index/store/split_store.dart:43: // may be already disposed in other thread ...

5 years, 3 months ago (2015-09-22 19:22:38 UTC) #2

scheglov

5 years, 3 months ago (2015-09-22 19:26:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
531f1d1e5bb94f02cbed35fecc4d32c0ec1428d7 (presubmit successful).

Expand Messages | Collapse Messages