Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: pkg/analysis_server/lib/src/services/index/index_contributor.dart

Issue 1359023002: Extract Dart specific node management into DartUnitIndexObjectManager. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/services/index/index_contributor.dart
diff --git a/pkg/analysis_server/lib/src/services/index/index_contributor.dart b/pkg/analysis_server/lib/src/services/index/index_contributor.dart
index a93b62c3a108f76c8f5b01c1303520553eb382cf..26397fbd3d9c32e000ff0fa042ac738801e3931e 100644
--- a/pkg/analysis_server/lib/src/services/index/index_contributor.dart
+++ b/pkg/analysis_server/lib/src/services/index/index_contributor.dart
@@ -35,7 +35,7 @@ void indexDartUnit(
return;
}
// about to index
- bool mayIndex = store.aboutToIndexDart(context, unitElement);
+ bool mayIndex = store.aboutToIndex(context, unitElement);
if (!mayIndex) {
return;
}
@@ -44,7 +44,7 @@ void indexDartUnit(
unit.accept(new _IndexContributor(store));
store.doneIndex();
} catch (e) {
- store.cancelIndexDart();
+ store.cancelIndex();
rethrow;
}
}
@@ -54,22 +54,23 @@ void indexDartUnit(
*/
void indexHtmlUnit(
InternalIndexStore store, AnalysisContext context, ht.HtmlUnit unit) {
- // check unit
- if (unit == null) {
- return;
- }
- // prepare unit element
- HtmlElement unitElement = unit.element;
- if (unitElement == null) {
- return;
- }
- // about to index
- bool mayIndex = store.aboutToIndexHtml(context, unitElement);
- if (!mayIndex) {
- return;
- }
- // do index
- store.doneIndex();
+ // TODO(scheglov) remove or implement
+// // check unit
+// if (unit == null) {
+// return;
+// }
+// // prepare unit element
+// HtmlElement unitElement = unit.element;
+// if (unitElement == null) {
+// return;
+// }
+// // about to index
+// bool mayIndex = store.aboutToIndexHtml(context, unitElement);
+// if (!mayIndex) {
+// return;
+// }
+// // do index
+// store.doneIndex();
}
/**

Powered by Google App Engine
This is Rietveld 408576698