Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1358773002: Load the native call wrapper via Thread. (Closed)

Created:
5 years, 3 months ago by rmacnak
Modified:
5 years, 3 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -195 lines) Patch
M runtime/vm/assembler.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/assembler.cc View 2 chunks +0 lines, -16 lines 0 comments Download
M runtime/vm/assembler_arm.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M runtime/vm/assembler_arm64.h View 1 chunk +0 lines, -4 lines 0 comments Download
M runtime/vm/assembler_arm64.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M runtime/vm/assembler_mips.h View 1 2 chunks +0 lines, -5 lines 0 comments Download
M runtime/vm/assembler_mips.cc View 1 2 chunks +0 lines, -22 lines 0 comments Download
M runtime/vm/assembler_x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M runtime/vm/assembler_x64.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/intermediate_language_ia32.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intermediate_language_mips.cc View 1 chunk +1 line, -5 lines 0 comments Download
M runtime/vm/intermediate_language_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/native_entry.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/native_entry.cc View 3 chunks +14 lines, -12 lines 0 comments Download
M runtime/vm/object.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/object.cc View 3 chunks +0 lines, -15 lines 0 comments Download
M runtime/vm/raw_object_snapshot.cc View 2 chunks +8 lines, -19 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 chunk +2 lines, -10 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 1 chunk +3 lines, -9 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/stub_code_mips.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
rmacnak
5 years, 3 months ago (2015-09-20 00:36:57 UTC) #2
Florian Schneider
lgtm
5 years, 3 months ago (2015-09-20 05:41:35 UTC) #3
rmacnak
5 years, 3 months ago (2015-09-20 20:48:22 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
f1a00564301ed824fd94ab993300d1e36b08522f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698