runtime/vm/stub_code_ia32.cc - Issue 1358773002: Load the native call wrapper via Thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 1358773002: Load the native call wrapper via Thread. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/stub_code_ia32.cc

diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc

index cfaab2842ab6bb1db93240ce201c2ce2cdac9964..f070b1be656e761e9c077e9a5b846c050801e3f3 100644

--- a/runtime/vm/stub_code_ia32.cc

+++ b/runtime/vm/stub_code_ia32.cc

@@ -179,7 +179,8 @@ void StubCode::GenerateCallNativeCFunctionStub(Assembler* assembler) {

__ movl(Address(ESP, 0), EAX); // Pass the pointer to the NativeArguments.

__ movl(Address(ESP, kWordSize), ECX); // Function to call.

- __ call(&NativeEntry::NativeCallWrapperLabel());

+ ExternalLabel label(NativeEntry::NativeCallWrapperEntry());

+ __ call(&label);

// Mark that the isolate is executing Dart code. EDI is callee saved.

__ movl(Address(EDI, Isolate::vm_tag_offset()),

« no previous file with comments | « runtime/vm/stub_code_arm64.cc ('k') | runtime/vm/stub_code_mips.cc » ('j') | no next file with comments »