Fix directory-listing, directory-deletion and file deletion, when links are involved.

Fix directory-listing, directory-deletion and file deletion, when links are involved.


BUG=https://code.google.com/p/dart/issues/detail?id=4928,https://code.google.com/p/dart/issues/detail?id=9278,https://code.google.com/p/dart/issues/detail?id=9504

Committed: https://code.google.com/p/dart/source/detail?r=20929

[Søren Gjesse, 2013-04-04 14:42:35]

lgtm with comments

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
File tests/standalone/io/directory_test.dart (right):

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:273: new File(l.path).deleteSync();
As discussed on chat this should fail as one cannot delete a directory using a
File object.

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:291: new File(l.path).deleteSync();
Ditto.

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:297: static void
testListBrokenLinkSync() {
Maybe extend this test to add both a file and a directory with links to both.
Then list with followLinks=true should give a file and a directory and list with
followLinks=false should give a file, a directory and two links. Deleting both
should then give two links.

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:318: static void testListLinkSync() {
This already does some of what I suggested above.

[Anders Johnsen, 2013-04-04 17:30:37]

Committed patchset #4 manually as r20929 (presubmit successful).

[Anders Johnsen, 2013-04-05 10:58:27]

Sadly, I can't test with links to files due to Windows limitation. Landing
without such tests, for now.

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
File tests/standalone/io/directory_test.dart (right):

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:273: new File(l.path).deleteSync();
On 2013/04/04 14:42:35, Søren Gjesse wrote:
> As discussed on chat this should fail as one cannot delete a directory using a
> File object.

Done.

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:291: new File(l.path).deleteSync();
On 2013/04/04 14:42:35, Søren Gjesse wrote:
> Ditto.

Done.

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:297: static void
testListBrokenLinkSync() {
On 2013/04/04 14:42:35, Søren Gjesse wrote:
> Maybe extend this test to add both a file and a directory with links to both.
> Then list with followLinks=true should give a file and a directory and list
with
> followLinks=false should give a file, a directory and two links. Deleting both
> should then give two links.

I can't as we can't link to files on Windows :(

https://codereview.chromium.org/13578003/diff/3007/tests/standalone/io/direct...
tests/standalone/io/directory_test.dart:318: static void testListLinkSync() {
On 2013/04/04 14:42:35, Søren Gjesse wrote:
> This already does some of what I suggested above.

Ditto.

[Bill Hesse, 2013-04-08 08:11:05]

LGTM.  I will add documentation for these behaviors in a followup CL.

[Bill Hesse, 2013-04-08 09:09:04]

LGTM.  I will add documentation for these behaviors in a followup CL.