Fix directory-listing, directory-deletion and file deletion, when links are involved.

tests/standalone/io/directory_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Directory listing test.
 
 import "dart:async";
 import "dart:io";
 import "dart:isolate";
 
@@ skipping 226 matching lines @@
     Expect.isTrue(d2.existsSync());
     Directory created = new Directory("${d.path}/subdir");
     created.createSync();
     Expect.isTrue(created.existsSync());
     created.deleteSync();
     Expect.isFalse(created.existsSync());
     d.deleteSync();
     Expect.isFalse(d.existsSync());
   }
 
+  static void testDeleteLinkSync() {
+    Directory tmp = new Directory("").createTempSync();
+    var path = "${tmp.path}${Platform.pathSeparator}";
+    Directory d = new Directory("${path}target");
+    d.createSync();
+    Link l = new Link("${path}symlink");
+    l.createSync("${path}target");
+    Expect.isTrue(d.existsSync());
+    Expect.isTrue(l.existsSync());
+    new Directory(l.path).deleteSync(recursive: true);
+    Expect.isTrue(d.existsSync());
+    Expect.isFalse(l.existsSync());
+    d.deleteSync();
+    Expect.isFalse(d.existsSync());
+    tmp.deleteSync();
+  }
+
+  static void testDeleteLinkAsFileSync() {
+    Directory tmp = new Directory("").createTempSync();
+    var path = "${tmp.path}${Platform.pathSeparator}";
+    Directory d = new Directory("${path}target");
+    d.createSync();
+    Link l = new Link("${path}symlink");
+    l.createSync("${path}target");
+    Expect.isTrue(d.existsSync());
+    Expect.isTrue(l.existsSync());
+    new File(l.path).deleteSync();

[Søren Gjesse, 2013/04/04 14:42:35]

As discussed on chat this should fail as one cannot delete a directory using a
File object.

[Anders Johnsen, 2013/04/05 10:58:27]

Done.

+    Expect.isTrue(d.existsSync());
+    Expect.isFalse(l.existsSync());
+    d.deleteSync();
+    Expect.isFalse(d.existsSync());
+    tmp.deleteSync();
+  }
+
+  static void testDeleteBrokenLinkAsFileSync() {
+    Directory tmp = new Directory("").createTempSync();
+    var path = "${tmp.path}${Platform.pathSeparator}";
+    Directory d = new Directory("${path}target");
+    d.createSync();
+    Link l = new Link("${path}symlink");
+    l.createSync("${path}target");
+    d.deleteSync();
+    Expect.isFalse(d.existsSync());
+    Expect.isTrue(l.existsSync());
+    new File(l.path).deleteSync();

[Søren Gjesse, 2013/04/04 14:42:35]

Ditto.

[Anders Johnsen, 2013/04/05 10:58:27]

Done.

+    Expect.isFalse(l.existsSync());
+    Expect.isFalse(d.existsSync());
+    tmp.deleteSync();
+  }
+
+  static void testListBrokenLinkSync() {

[Søren Gjesse, 2013/04/04 14:42:35]

Maybe extend this test to add both a file and a directory with links to both.
Then list with followLinks=true should give a file and a directory and list with
followLinks=false should give a file, a directory and two links. Deleting both
should then give two links.

[Anders Johnsen, 2013/04/05 10:58:27]

I can't as we can't link to files on Windows :(

+    Directory tmp = new Directory("").createTempSync();
+    var path = "${tmp.path}${Platform.pathSeparator}";
+    Directory d = new Directory("${path}target");
+    d.createSync();
+    Link l = new Link("${path}symlink");
+    l.createSync("${path}target");
+    d.deleteSync();
+    int count = 0;
+    tmp.list(followLinks: true).listen(
+        (file) {
+          count++;
+          Expect.isTrue(file is Link);
+        },
+        onDone: () {
+          Expect.equals(1, count);
+          l.deleteSync();
+          tmp.deleteSync();
+        });
+  }
+
+  static void testListLinkSync() {

[Søren Gjesse, 2013/04/04 14:42:35]

This already does some of what I suggested above.

[Anders Johnsen, 2013/04/05 10:58:27]

Ditto.

+    Directory tmp = new Directory("").createTempSync();
+    var path = "${tmp.path}${Platform.pathSeparator}";
+    Directory d = new Directory("${path}target");
+    d.createSync();
+    Link l = new Link("${path}symlink");
+    l.createSync("${path}target");
+    int count = 0;
+    tmp.list(followLinks: true).listen(
+        (file) {
+          count++;
+          Expect.isTrue(file is Directory);
+        },
+        onDone: () {
+          Expect.equals(2, count);
+          l.deleteSync();
+          d.deleteSync();
+          tmp.deleteSync();
+        });
+  }
+
   static void testCreateTemp([String template = ""]) {
     var port = new ReceivePort();
     Directory dir = new Directory(template);
     Future.wait([dir.createTemp(), dir.createTemp()])
       .then((tempDirs) {
         Expect.notEquals(tempDirs[0].path, tempDirs[1].path);
         for (Directory t in tempDirs) {
           Expect.isTrue(t.existsSync());
           t.deleteSync();
           Expect.isFalse(t.existsSync());
@@ skipping 50 matching lines @@
   static void testMain() {
     testListing();
     testListNonExistent();
     testListTooLongName();
     testDeleteNonExistent();
     testDeleteTooLongName();
     testDeleteNonExistentSync();
     testDeleteTooLongNameSync();
     testExistsCreateDelete();
     testExistsCreateDeleteSync();
+    testDeleteLinkSync();
+    testDeleteLinkAsFileSync();
+    testDeleteBrokenLinkAsFileSync();
+    testListBrokenLinkSync();
+    testListLinkSync();
     testCreateTemp();
     testCreateDeleteTemp();
     testCurrent();
     testFromPath();
   }
 }
 
 
 class NestedTempDirectoryTest {
   List<Directory> createdDirectories;
@@ skipping 192 matching lines @@
   testCreateTempErrorSync();
   testCreateTempError();
   testCreateExistingSync();
   testCreateExisting();
   testCreateDirExistingFileSync();
   testCreateDirExistingFile();
   testCreateRecursive();
   testCreateRecursiveSync();
   testRename();
 }