Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issue 1357023004: Catch unexpected http uri error in service isolate (Closed)

Created:
5 years, 3 months ago by Cutch
Modified:
5 years, 3 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Catch unexpected http uri error in service isolate Fixes #24388 R=iposva@google.com Committed: https://github.com/dart-lang/sdk/commit/f6e0a8f30b32af16f9fede4b65698ebfacb28d91

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M runtime/bin/vmservice/server.dart View 1 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 3 months ago (2015-09-21 17:32:50 UTC) #2
Ivan Posva
LGTM -ip
5 years, 3 months ago (2015-09-21 17:33:23 UTC) #3
Ivan Posva
Should we also print the "bytes" that make up the URI so that we know ...
5 years, 3 months ago (2015-09-21 17:46:57 UTC) #4
Cutch
5 years, 3 months ago (2015-09-21 18:01:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
f6e0a8f30b32af16f9fede4b65698ebfacb28d91 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698