Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Unified Diff: runtime/bin/vmservice/server.dart

Issue 1357023004: Catch unexpected http uri error in service isolate (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/vmservice/server.dart
diff --git a/runtime/bin/vmservice/server.dart b/runtime/bin/vmservice/server.dart
index 34d57158032e8e15162069b1860d7af2a489ca6f..8697e659259c0b7ddb3662e2aa17733c492fabb5 100644
--- a/runtime/bin/vmservice/server.dart
+++ b/runtime/bin/vmservice/server.dart
@@ -146,9 +146,16 @@ class Server {
return;
}
// HTTP based service request.
- var client = new HttpRequestClient(request, _service);
- var message = new Message.fromUri(client, request.uri);
- client.onMessage(null, message);
+ try {
+ var client = new HttpRequestClient(request, _service);
+ var message = new Message.fromUri(client, request.uri);
+ client.onMessage(null, message);
+ } catch (e) {
+ print('Unexpected error processing HTTP request uri: '
+ '${request.uri}\n$e\n');
+ rethrow;
+ }
+
}
Future startup() {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698