Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1356943002: remove docgen from the sdk, and generating docs with docgen (Closed)

Created:
5 years, 3 months ago by keertip
Modified:
5 years, 3 months ago
Reviewers:
Bill Hesse
CC:
reviews_dartlang.org, ricow1
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : add utils_wrapper snapshot #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -54 lines) Patch
M README.dart-sdk View 1 chunk +1 line, -1 line 0 comments Download
M dart.gyp View 1 chunk +0 lines, -7 lines 0 comments Download
M tools/bots/dart_sdk.py View 3 chunks +0 lines, -44 lines 0 comments Download
M tools/create_sdk.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
keertip
5 years, 3 months ago (2015-09-18 16:56:40 UTC) #2
Bill Hesse
LGTM with comment https://codereview.chromium.org/1356943002/diff/1/tools/create_sdk.py File tools/create_sdk.py (left): https://codereview.chromium.org/1356943002/diff/1/tools/create_sdk.py#oldcode131 tools/create_sdk.py:131: 'utils_wrapper', 'pub', 'dartdoc']: This is used ...
5 years, 3 months ago (2015-09-18 19:33:40 UTC) #3
keertip
On 2015/09/18 19:33:40, Bill Hesse wrote: > LGTM with comment > > https://codereview.chromium.org/1356943002/diff/1/tools/create_sdk.py > File ...
5 years, 3 months ago (2015-09-18 20:17:13 UTC) #4
keertip
5 years, 3 months ago (2015-09-18 20:18:20 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
3d37a55dceb313412e2f6da5354583d72acfd2db (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698