Issue 1355953002: Fix lazy deoptimization from deferred code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1355953002: Fix lazy deoptimization from deferred code. (Closed)

Created:
5 years, 3 months ago by Florian Schneider

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix lazy deoptimization from deferred code. Insert enough padding to ensure enough space for when lazy deoptimization occurs from the last deferred code object. Also, speed up ia32 disassembler to avoid tests timing out. BUG= TBR=rmacnak@google.com, Committed: https://github.com/dart-lang/sdk/commit/18faa55764fecc021411e87070bd3868697a689c

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -16 lines)			Patch
M	runtime/vm/disassembler.cc	View	1 2 3	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/vm/disassembler_ia32.cc	View	1 2 3	2 chunks	+1 line, -10 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/instructions_arm.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/instructions_arm.cc	View	1	1 chunk	+7 lines, -3 lines	0 comments	Download
M	runtime/vm/instructions_arm64.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/instructions_mips.h	View	1	1 chunk	+3 lines, -1 line	0 comments	Download

Total messages: 4 (1 generated)

Florian Schneider

Committed patchset #4 (id:60001) manually as 18faa55764fecc021411e87070bd3868697a689c.

5 years, 3 months ago (2015-09-19 16:00:41 UTC) #3

Message was sent while issue was closed.

lgtm