Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1034)

Side by Side Diff: runtime/vm/flow_graph_compiler_ia32.cc

Issue 1355953002: Fix lazy deoptimization from deferred code. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: speed up ia32 disassembler Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_IA32.
6 #if defined(TARGET_ARCH_IA32) 6 #if defined(TARGET_ARCH_IA32)
7 7
8 #include "vm/flow_graph_compiler.h" 8 #include "vm/flow_graph_compiler.h"
9 9
10 #include "vm/ast_printer.h" 10 #include "vm/ast_printer.h"
11 #include "vm/code_patcher.h" 11 #include "vm/code_patcher.h"
12 #include "vm/compiler.h" 12 #include "vm/compiler.h"
13 #include "vm/cpu.h" 13 #include "vm/cpu.h"
14 #include "vm/dart_entry.h" 14 #include "vm/dart_entry.h"
15 #include "vm/deopt_instructions.h" 15 #include "vm/deopt_instructions.h"
16 #include "vm/flow_graph_builder.h" 16 #include "vm/flow_graph_builder.h"
17 #include "vm/il_printer.h" 17 #include "vm/il_printer.h"
18 #include "vm/instructions.h"
18 #include "vm/locations.h" 19 #include "vm/locations.h"
19 #include "vm/object_store.h" 20 #include "vm/object_store.h"
20 #include "vm/parser.h" 21 #include "vm/parser.h"
21 #include "vm/stack_frame.h" 22 #include "vm/stack_frame.h"
22 #include "vm/stub_code.h" 23 #include "vm/stub_code.h"
23 #include "vm/symbols.h" 24 #include "vm/symbols.h"
24 #include "vm/verified_memory.h" 25 #include "vm/verified_memory.h"
25 26
26 namespace dart { 27 namespace dart {
27 28
(...skipping 1093 matching lines...) Expand 10 before | Expand all | Expand 10 after
1121 } 1122 }
1122 } 1123 }
1123 1124
1124 ASSERT(!block_order().is_empty()); 1125 ASSERT(!block_order().is_empty());
1125 VisitBlocks(); 1126 VisitBlocks();
1126 1127
1127 __ int3(); 1128 __ int3();
1128 GenerateDeferredCode(); 1129 GenerateDeferredCode();
1129 1130
1130 if (is_optimizing()) { 1131 if (is_optimizing()) {
1132 // Leave enough space for patching in case of lazy deoptimization from
1133 // deferred code.
1134 __ nop(CallPattern::pattern_length_in_bytes());
1131 lazy_deopt_pc_offset_ = assembler()->CodeSize(); 1135 lazy_deopt_pc_offset_ = assembler()->CodeSize();
1132 __ Jmp(*StubCode::DeoptimizeLazy_entry()); 1136 __ Jmp(*StubCode::DeoptimizeLazy_entry());
1133 } 1137 }
1134 } 1138 }
1135 1139
1136 1140
1137 void FlowGraphCompiler::GenerateCall(intptr_t token_pos, 1141 void FlowGraphCompiler::GenerateCall(intptr_t token_pos,
1138 const StubEntry& stub_entry, 1142 const StubEntry& stub_entry,
1139 RawPcDescriptors::Kind kind, 1143 RawPcDescriptors::Kind kind,
1140 LocationSummary* locs) { 1144 LocationSummary* locs) {
(...skipping 692 matching lines...) Expand 10 before | Expand all | Expand 10 after
1833 __ movups(reg, Address(ESP, 0)); 1837 __ movups(reg, Address(ESP, 0));
1834 __ addl(ESP, Immediate(kFpuRegisterSize)); 1838 __ addl(ESP, Immediate(kFpuRegisterSize));
1835 } 1839 }
1836 1840
1837 1841
1838 #undef __ 1842 #undef __
1839 1843
1840 } // namespace dart 1844 } // namespace dart
1841 1845
1842 #endif // defined TARGET_ARCH_IA32 1846 #endif // defined TARGET_ARCH_IA32
OLDNEW
« no previous file with comments | « runtime/vm/flow_graph_compiler_arm64.cc ('k') | runtime/vm/flow_graph_compiler_mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698