Issue 13529005: Fix view creation for byte-size types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13529005: Fix view creation for byte-size types. (Closed)

Created:
7 years, 8 months ago by Mads Ager (google)

Modified:
7 years, 8 months ago

Reviewers:
siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix view creation for byte-size types. We had forgotten to subtract the start byte offset from the length when not passing in an explicit length. Additionally, fix a couple of checked mode issues. R=asiva@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20867

Patch Set 1 #

Patch Set 2 : Fix checked mode problems #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -6 lines)			Patch
	M	runtime/lib/typeddata.dart	View	1	6 chunks	+6 lines, -6 lines	0 comments	Download
	M	tests/standalone/typed_data_test.dart	View	1	2 chunks	+36 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (google)

7 years, 8 months ago (2013-04-03 15:29:20 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20867 (presubmit successful).

Expand Messages | Collapse Messages