Fix view creation for byte-size types.

runtime/lib/typeddata.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // patch classes for Int8List ..... Float64List and ByteData implementations.
 
 patch class Int8List {
   /* patch */ factory Int8List(int length) {
     return new _Int8Array(length);
   }
@@ skipping 260 matching lines @@
   }
 
   /* patch */ factory ByteData.transferable(int length) {
     var list = new _Uint8Array.transferable(length);
     return new _ByteDataView(list.buffer, 0, length);
   }
 
   /* patch */ factory ByteData.view(ByteBuffer buffer,
                                     [int offsetInBytes = 0, int length]) {
     if (length == null) {
-      length = buffer.lengthInBytes;
+      length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _ByteDataView(buffer, offsetInBytes, length);
   }
 }
 
 
 // Based class for _TypedList that provides common methods for implementing
 // the collection and list interfaces.
 
 abstract class _TypedListBase {
@@ skipping 13 matching lines @@
 
   String join([String separator]) {
     return IterableMixinWorkaround.join(this, separator);
   }
 
   dynamic reduce(dynamic initialValue,
                  dynamic combine(dynamic initialValue, element)) {
     return IterableMixinWorkaround.reduce(this, initialValue, combine);
   }
 
-  Collection where(bool f(int element)) {
+  Iterable where(bool f(int element)) {
     return IterableMixinWorkaround.where(this, f);
   }
 
   Iterable expand(Iterable f(int element)) {
     return IterableMixinWorkaround.expand(this, f);
   }
 
   Iterable take(int n) {
     return IterableMixinWorkaround.takeList(this, n);
   }
@@ skipping 245 matching lines @@
     if (length < 0) {
       String message = "$length must be greater than 0";
       throw new ArgumentError(message);
     }
     return _new(length);
   }
 
   factory _Int8Array.view(ByteBuffer buffer,
                           [int offsetInBytes = 0, int length]) {
     if (length == null) {
-      length = buffer.lengthInBytes;
+      length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _Int8ArrayView(buffer, offsetInBytes, length);
   }
 
 
   // Method(s) implementing List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
@@ skipping 37 matching lines @@
     if (length < 0) {
       String message = "$length must be greater than 0";
       throw new ArgumentError(message);
     }
     return _new(length);
   }
 
   factory _Uint8Array.view(ByteBuffer buffer,
                            [int offsetInBytes = 0, int length]) {
     if (length == null) {
-      length = buffer.lengthInBytes;
+      length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _Uint8ArrayView(buffer, offsetInBytes, length);
   }
 
 
   // Methods implementing List interface.
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
     }
@@ skipping 35 matching lines @@
     if (length < 0) {
       String message = "$length must be greater than 0";
       throw new ArgumentError(message);
     }
     return _new(length);
   }
 
   factory _Uint8ClampedArray.view(ByteBuffer buffer,
                                   [int offsetInBytes = 0, int length]) {
     if (length == null) {
-      length = buffer.lengthInBytes;
+      length = buffer.lengthInBytes - offsetInBytes;
     }
     return new _Uint8ClampedArrayView(buffer, offsetInBytes, length);
   }
 
 
   // Methods implementing List interface.
 
   int operator[](int index) {
     if (index < 0 || index >= length) {
       _throwRangeError(index, length);
@@ skipping 1609 matching lines @@
 
 
   // Internal utility methods.
 
   Uint8List _createList(int length) {
     return new Uint8List(length);
   }
 }
 
 
-class _Uint8ClampedArrayView extends _TypedListView implements Uint8List {
+class _Uint8ClampedArrayView extends _TypedListView implements Uint8ClampedList {
   // Constructor.
   _Uint8ClampedArrayView(ByteBuffer buffer,
                          [int _offsetInBytes = 0, int _length])
     : super(buffer, _offsetInBytes,
             _defaultIfNull(_length,
                            ((buffer.lengthInBytes - _offsetInBytes) ~/
                             Uint8List.BYTES_PER_ELEMENT))) {
     _rangeCheck(buffer.lengthInBytes,
                 offsetInBytes,
                 length * Uint8List.BYTES_PER_ELEMENT);
@@ skipping 745 matching lines @@
     return value;
   }
   return object;
 }
 
 
 void _throwRangeError(int index, int length) {
   String message = "$index must be in the range [0..$length)";
   throw new RangeError(message);
 }