Issue 1350423002: Partially fix the cache invalidation problem during incremental resolution.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1350423002: Partially fix the cache invalidation problem during incremental resolution. (Closed)

Created:
5 years, 3 months ago by scheglov

Modified:
5 years, 3 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Partially fix the cache invalidation problem during incremental resolution. It still takes 90% of total incremental resolution time. But at least it's not 10 seconds anymore, just 300ms in Analyzer + Server, or 80ms in pure Analyzer. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/14b726f3e6bc09050c2f5baed5fe6e687af79351

Patch Set 1 #

Total comments: 1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+62 lines, -20 lines)			Patch
	M	pkg/analyzer/lib/src/context/cache.dart	View		7 chunks	+38 lines, -17 lines	1 comment	Download
	M	pkg/analyzer/lib/src/generated/incremental_resolver.dart	View		2 chunks	+24 lines, -3 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1350423002/diff/1/pkg/analyzer/lib/src/context/cache.dart File pkg/analyzer/lib/src/context/cache.dart (right): https://codereview.chromium.org/1350423002/diff/1/pkg/analyzer/lib/src/context/cache.dart#newcode542 pkg/analyzer/lib/src/context/cache.dart:542: // { If you didn't intend to leave ...

5 years, 3 months ago (2015-09-18 18:37:42 UTC) #2

scheglov

5 years, 3 months ago (2015-09-18 19:02:35 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
14b726f3e6bc09050c2f5baed5fe6e687af79351 (presubmit successful).

Expand Messages | Collapse Messages