Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(392)

Unified Diff: pkg/analyzer/lib/src/generated/incremental_resolver.dart

Issue 1350423002: Partially fix the cache invalidation problem during incremental resolution. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analyzer/lib/src/generated/incremental_resolver.dart
diff --git a/pkg/analyzer/lib/src/generated/incremental_resolver.dart b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
index 2d501fb55e3d8a763ebc5bea6999efc9265dafa7..84047e4d8df490b205f8c621b1b6d07c9a699319 100644
--- a/pkg/analyzer/lib/src/generated/incremental_resolver.dart
+++ b/pkg/analyzer/lib/src/generated/incremental_resolver.dart
@@ -864,6 +864,22 @@ class IncrementalBodyDelta extends Delta {
if (descriptor == CONTENT) {
return DeltaResult.KEEP_CONTINUE;
}
+ if (target is Source && target != source) {
+ if (isByTask(DartErrorsTask.DESCRIPTOR) ||
+ isByTask(LibraryErrorsReadyTask.DESCRIPTOR)) {
+ return DeltaResult.KEEP_CONTINUE;
+ }
+ }
+ if (target is LibrarySpecificUnit &&
+ target.unit != source &&
+ target.library != source) {
+ if (isByTask(GatherUsedLocalElementsTask.DESCRIPTOR) ||
+ isByTask(GatherUsedImportedElementsTask.DESCRIPTOR) ||
+ isByTask(GenerateHintsTask.DESCRIPTOR) ||
+ isByTask(LibraryUnitErrorsTask.DESCRIPTOR)) {
+ return DeltaResult.KEEP_CONTINUE;
+ }
+ }
if (isByTask(BuildCompilationUnitElementTask.DESCRIPTOR) ||
isByTask(BuildDirectiveElementsTask.DESCRIPTOR) ||
isByTask(BuildEnumMemberElementsTask.DESCRIPTOR) ||
@@ -1251,9 +1267,14 @@ class IncrementalResolver {
void _updateCache() {
if (newSourceEntry != null) {
- newSourceEntry.setState(CONTENT, CacheState.INVALID,
- delta: new IncrementalBodyDelta(_source, _updateOffset, _updateEndOld,
- _updateEndNew, _updateDelta));
+ LoggingTimer timer = logger.startTimer();
+ try {
+ newSourceEntry.setState(CONTENT, CacheState.INVALID,
+ delta: new IncrementalBodyDelta(_source, _updateOffset,
+ _updateEndOld, _updateEndNew, _updateDelta));
+ } finally {
+ timer.stop('invalidate cache with delta');
+ }
}
}
« pkg/analyzer/lib/src/context/cache.dart ('K') | « pkg/analyzer/lib/src/context/cache.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698