Implements optional parameter handling in MIPS vm.

Implements optional parameter handling in MIPS vm.

- Deocdes ic data and argument descriptor.
- Removes SUB instruction from assembler and disassembler.
Committed: https://code.google.com/p/dart/source/detail?r=20895

[zra, 2013-04-03 20:18:58]

Note the FindCodeObject test modified for MIPS following our discussion this
morning.

Thanks!
Zach

[regis, 2013-04-03 21:12:39]

LGTM

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/assembler_mips_...
File runtime/vm/assembler_mips_test.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/assembler_mips_...
runtime/vm/assembler_mips_test.cc:1001: __ jr(RA);
Whether the branch is taken or not, the returned result will be zero. How about
inserting LoadImmediate(V0, 1); jr(RA); before the Bind?

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/assembler_mips_...
runtime/vm/assembler_mips_test.cc:1017: 
ditto

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/code_patcher_mi...
File runtime/vm/code_patcher_mips.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/code_patcher_mi...
runtime/vm/code_patcher_mips.cc:62: // The instance call instruction sequence
has a variable size on ARM.
ARM -> MIPS

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/find_code_objec...
File runtime/vm/find_code_object_test.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/find_code_objec...
runtime/vm/find_code_object_test.cc:22: const int kLoopCount = 1818;
I would add a TODO(zra): Increase this count once we implement far branches on
MIPS.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_mips.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_mips.cc:230: __ addiu(T2, T2, Immediate(-1));
You could spare the instruction sll(T3, T2, 2) by decrementing T2 by 4 instead
of 1.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_mips.cc:397: __ addiu(T2, T2, Immediate(-1));
You could spare the instruction sll(T3, T2, 2) by decrementing T2 by 4 instead
of 1.

[zra, 2013-04-03 21:41:00]

Thanks!

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/assembler_mips_...
File runtime/vm/assembler_mips_test.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/assembler_mips_...
runtime/vm/assembler_mips_test.cc:1001: __ jr(RA);
On 2013/04/03 21:12:39, regis wrote:
> Whether the branch is taken or not, the returned result will be zero. How
about
> inserting LoadImmediate(V0, 1); jr(RA); before the Bind?

Done.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/assembler_mips_...
runtime/vm/assembler_mips_test.cc:1017: 
On 2013/04/03 21:12:39, regis wrote:
> ditto

Done.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/code_patcher_mi...
File runtime/vm/code_patcher_mips.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/code_patcher_mi...
runtime/vm/code_patcher_mips.cc:62: // The instance call instruction sequence
has a variable size on ARM.
On 2013/04/03 21:12:39, regis wrote:
> ARM -> MIPS

Done.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/find_code_objec...
File runtime/vm/find_code_object_test.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/find_code_objec...
runtime/vm/find_code_object_test.cc:22: const int kLoopCount = 1818;
On 2013/04/03 21:12:39, regis wrote:
> I would add a TODO(zra): Increase this count once we implement far branches on
> MIPS.

Done.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/flow_graph_comp...
File runtime/vm/flow_graph_compiler_mips.cc (right):

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_mips.cc:230: __ addiu(T2, T2, Immediate(-1));
On 2013/04/03 21:12:39, regis wrote:
> You could spare the instruction sll(T3, T2, 2) by decrementing T2 by 4 instead
> of 1.

Done.

https://codereview.chromium.org/13474009/diff/7001/runtime/vm/flow_graph_comp...
runtime/vm/flow_graph_compiler_mips.cc:397: __ addiu(T2, T2, Immediate(-1));
On 2013/04/03 21:12:39, regis wrote:
> You could spare the instruction sll(T3, T2, 2) by decrementing T2 by 4 instead
> of 1.

Done.

[zra, 2013-04-03 21:44:01]

Committed patchset #3 manually as r20895 (presubmit successful).

[regis, 2013-04-03 21:44:29]

https://codereview.chromium.org/13474009/diff/14001/runtime/vm/assembler_mips...
File runtime/vm/assembler_mips_test.cc (right):

https://codereview.chromium.org/13474009/diff/14001/runtime/vm/assembler_mips...
runtime/vm/assembler_mips_test.cc:999: __ LoadImmediate(V0, 1);
You still miss the jr(RA), otherwise 1 is overwritten with 0 below.

https://codereview.chromium.org/13474009/diff/14001/runtime/vm/assembler_mips...
runtime/vm/assembler_mips_test.cc:1019: __ LoadImmediate(V0, 1);
ditto

https://codereview.chromium.org/13474009/diff/14001/runtime/vm/flow_graph_com...
File runtime/vm/flow_graph_compiler_mips.cc (right):

https://codereview.chromium.org/13474009/diff/14001/runtime/vm/flow_graph_com...
runtime/vm/flow_graph_compiler_mips.cc:229: __ addiu(T2, T2, Immediate(-4));
-kWordSize would be better.

https://codereview.chromium.org/13474009/diff/14001/runtime/vm/flow_graph_com...
runtime/vm/flow_graph_compiler_mips.cc:395: __ addiu(T2, T2, Immediate(-4));
ditto