Issue 1347363004: Speedup x64 disassembler to avoid tests timing out.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1347363004: Speedup x64 disassembler to avoid tests timing out. (Closed)

Created:
5 years, 3 months ago by Florian Schneider

Modified:
5 years, 3 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Speedup x64 disassembler to avoid tests timing out. Same change as I already did for ia32. We don't have a lot of raw addresses embedded in code anymore with the new calling convention, so this part of the disassembler is not useful anymore. TBR=rmacnak Committed: https://github.com/dart-lang/sdk/commit/2bbf0c61ae8995eca5b8a5423ec7bc924e6e58a5

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -9 lines)			Patch
	M	runtime/vm/disassembler_x64.cc	View		3 chunks	+3 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Florian Schneider

Committed patchset #1 (id:1) manually as 2bbf0c61ae8995eca5b8a5423ec7bc924e6e58a5 (presubmit successful).

5 years, 3 months ago (2015-09-21 10:56:32 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages