Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: runtime/vm/disassembler_x64.cc

Issue 1347363004: Speedup x64 disassembler to avoid tests timing out. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/disassembler_x64.cc
diff --git a/runtime/vm/disassembler_x64.cc b/runtime/vm/disassembler_x64.cc
index ffd610823ec0fc88008c59534efa829a436ec04c..4778695cafe2432d997ac75c2aa97046ddcdf8ec 100644
--- a/runtime/vm/disassembler_x64.cc
+++ b/runtime/vm/disassembler_x64.cc
@@ -790,7 +790,8 @@ static const char* ObjectToCStringNoGC(const Object& obj) {
obj.IsClass() ||
obj.IsFunction() ||
obj.IsICData() ||
- obj.IsField()) {
+ obj.IsField() ||
+ obj.IsCode()) {
return obj.ToCString();
}
@@ -808,6 +809,7 @@ void DisassemblerX64::AppendAddressToBuffer(uint8_t* addr_byte_ptr) {
if (((addr & kSmiTagMask) == kHeapObjectTag) &&
reinterpret_cast<RawObject*>(addr)->IsWellFormed() &&
reinterpret_cast<RawObject*>(addr)->IsOldObject() &&
+ !Dart::vm_isolate()->heap()->CodeContains(addr) &&
!Isolate::Current()->heap()->CodeContains(addr) &&
Disassembler::CanFindOldObject(addr)) {
NoSafepointScope no_safepoint;
@@ -835,14 +837,6 @@ void DisassemblerX64::AppendAddressToBuffer(uint8_t* addr_byte_ptr) {
const char* name_of_stub = StubCode::NameOfStub(addr);
if (name_of_stub != NULL) {
AppendToBuffer(" [stub: %s]", name_of_stub);
- } else {
- // Print only if jumping to entry point.
- const Code& code = Code::Handle(Code::LookupCode(addr));
- if (!code.IsNull() && (code.EntryPoint() == addr)) {
- const String& name = String::Handle(code.PrettyName());
- const char* name_c = name.ToCString();
- AppendToBuffer(" [%s]", name_c);
- }
}
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698