Issue 13471015: Ensure apidoc exits with non-zero exit code when dart2js crashes.

Issue 13471015: Ensure apidoc exits with non-zero exit code when dart2js crashes. (Closed)

Created:
7 years, 8 months ago by ahe

Modified:
7 years, 8 months ago

Reviewers:
Johnni Winther, kevmoo-old, Andrei Mouravski

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Ensure apidoc exits with non-zero exit code when dart2js crashes. Also, print the stack trace when dart2js crashes. Committed: https://code.google.com/p/dart/source/detail?r=20912

Patch Set 2 : Call cleanup #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
	M	dart/utils/apidoc/apidoc.dart	View	1	1 chunk	+5 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

kevmoo-old

DBQ https://codereview.chromium.org/13471015/diff/1/dart/utils/apidoc/apidoc.dart File dart/utils/apidoc/apidoc.dart (right): https://codereview.chromium.org/13471015/diff/1/dart/utils/apidoc/apidoc.dart#newcode154 dart/utils/apidoc/apidoc.dart:154: print('Error: generation failed: ${e}'); Does apidoc.cleanup() get called ...

7 years, 8 months ago (2013-04-03 02:08:48 UTC) #3

ahe

https://codereview.chromium.org/13471015/diff/1/dart/utils/apidoc/apidoc.dart File dart/utils/apidoc/apidoc.dart (right): https://codereview.chromium.org/13471015/diff/1/dart/utils/apidoc/apidoc.dart#newcode154 dart/utils/apidoc/apidoc.dart:154: print('Error: generation failed: ${e}'); On 2013/04/03 02:08:49, kevmoo wrote: ...

7 years, 8 months ago (2013-04-04 10:26:01 UTC) #4

ahe

7 years, 8 months ago (2013-04-04 10:32:29 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 manually as r20912 (presubmit successful).

Expand Messages | Collapse Messages