dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart - Issue 13471015: Ensure apidoc exits with non-zero exit code when dart2js crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart

Issue 13471015: Ensure apidoc exits with non-zero exit code when dart2js crashes. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Call cleanup Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart

diff --git a/dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart b/dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart

index c84c72c7d717860bab8bcfdefa2974ed9e990cac..658b2338e65569bf0feffa94e9b2083c10e0f502 100644

--- a/dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart

+++ b/dart/sdk/lib/_internal/dartdoc/bin/dartdoc.dart

@@ -251,8 +251,9 @@ main() {

}

})

.catchError((e) {

- print('Error: generation failed: ${e.error}');

- exit(1);

+ print('Error: generation failed: ${e}');

+ dartdoc.cleanup();

+ exit(1);

})

.whenComplete(() => dartdoc.cleanup());

}

« no previous file with comments | « no previous file | dart/utils/apidoc/apidoc.dart » ('j') | no next file with comments »