Issue 1346333003: Make old-space heap stats safe for parallel marking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1346333003: Make old-space heap stats safe for parallel marking. (Closed)

Created:
5 years, 3 months ago by koda

Modified:
5 years, 3 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Make old-space heap stats safe for parallel marking. Record live count/size stats locally in each marking task and sum the results at the end. This is needed for parallel (and later, concurrent) marking. This also yields a more compact representation of the stats compared to ClassHeapStats, which interleaves new/old/etc. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/b62e3204ed5ed42352fc451e4bee3924abc65952

Patch Set 1 #

Patch Set 2 : Fix count. #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -12 lines)			Patch
M	runtime/vm/class_table.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	runtime/vm/class_table.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	runtime/vm/gc_marker.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	runtime/vm/gc_marker.cc	View		4 chunks	+38 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

5 years, 3 months ago (2015-09-16 22:09:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
b62e3204ed5ed42352fc451e4bee3924abc65952 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages