runtime/vm/gc_marker.h - Issue 1346333003: Make old-space heap stats safe for parallel marking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/gc_marker.h

Issue 1346333003: Make old-space heap stats safe for parallel marking. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Fix count. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/gc_marker.h

diff --git a/runtime/vm/gc_marker.h b/runtime/vm/gc_marker.h

index fb0b85d4c3989a7c6ac0c5b260893b43acbe9794..c01a6e8e5374a99de4cfbbccb55f0e9f777ebfa8 100644

--- a/runtime/vm/gc_marker.h

+++ b/runtime/vm/gc_marker.h

@@ -49,8 +49,10 @@ class GCMarker : public ValueObject {

// Called by anyone: finalize and accumulate stats from 'visitor'.

void FinalizeResultsFrom(MarkingVisitor* visitor);

- Monitor monitor_; // Protects marked_bytes_ and done_count_.

Heap* heap_;

+ Mutex stats_mutex_;

+ // TODO(koda): Remove after verifying it's redundant w.r.t. ClassHeapStats.

uintptr_t marked_bytes_;

friend class MarkTask;

« no previous file with comments | « runtime/vm/class_table.cc ('k') | runtime/vm/gc_marker.cc » ('j') | no next file with comments »