Issue 134623003: Revert "Revert "Revert "Fix dart2js type warnings"""

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 134623003: Revert "Revert "Revert "Fix dart2js type warnings""" (Closed)

Created:
6 years, 11 months ago by vsm

Modified:
6 years, 11 months ago

Reviewers:
blois

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Revert "Revert "Fix dart2js type warnings""" Hitting layout test failures in Dartium now.... TBR=blois@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=31702

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -279 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	6 chunks	+2 lines, -55 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	10 chunks	+5 lines, -119 lines	0 comments	Download
M	sdk/lib/svg/dart2js/svg_dart2js.dart	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	sdk/lib/svg/dartium/svg_dartium.dart	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	tests/compiler/dart2js/analyze_api_test.dart	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tools/dom/dom.json	View	17 chunks	+0 lines, -63 lines	0 comments	Download
M	tools/dom/idl/dart/dart.idl	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	tools/dom/scripts/htmldartgenerator.py	View	2 chunks	+2 lines, -8 lines	0 comments	Download

Total messages: 1 (0 generated)

vsm

6 years, 11 months ago (2014-01-10 19:27:18 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 manually as r31702 (presubmit successful).