Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Unified Diff: tools/dom/scripts/htmldartgenerator.py

Issue 134623003: Revert "Revert "Revert "Fix dart2js type warnings""" (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/idl/dart/dart.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/scripts/htmldartgenerator.py
diff --git a/tools/dom/scripts/htmldartgenerator.py b/tools/dom/scripts/htmldartgenerator.py
index 4d90ce92383a0ce00dd63631e0a28d8506a7b25b..d549d981154a9873480fb08c25e0c4f30d76cc3a 100644
--- a/tools/dom/scripts/htmldartgenerator.py
+++ b/tools/dom/scripts/htmldartgenerator.py
@@ -111,19 +111,15 @@ class HtmlDartGenerator(object):
# interfaces need to be added. Sometimes the attribute or operation is
# defined in the current interface as well as a parent. In that case we
# avoid making a duplicate definition and pray that the signatures match.
- inherited_attrs = []
- inherited_ops = []
secondary_parents = self._database.TransitiveSecondaryParents(interface)
for parent_interface in sorted(secondary_parents):
if isinstance(parent_interface, str):
continue
for attr in sorted(parent_interface.attributes, ConstantOutputOrder):
- if (not FindMatchingAttribute(interface, attr) or
- attr.id not in inherited_attrs):
+ if not FindMatchingAttribute(interface, attr):
if attr.type.id != 'EventHandler':
self.SecondaryContext(parent_interface)
self.AddAttribute(attr)
- inherited_attrs.append(attr.id)
# Group overloaded operations by name.
operationsByName =self._OperationsByName(parent_interface)
@@ -134,13 +130,11 @@ class HtmlDartGenerator(object):
# Generate operations.
for id in sorted(operationsByName.keys()):
- if (not any(op.id == id for op in interface.operations)
- or id not in inherited_ops):
+ if not any(op.id == id for op in interface.operations):
operations = operationsByName[id]
info = AnalyzeOperation(interface, operations)
self.SecondaryContext(parent_interface)
self.AddOperation(info)
- inherited_ops.append(id)
def _RemoveShadowingOperationsWithSameSignature(self, operationsByName,
interface):
« no previous file with comments | « tools/dom/idl/dart/dart.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698