Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1346133002: Report hint on unmatched show and hide combinators. (Closed)

Created:
5 years, 3 months ago by Johnni Winther
Modified:
5 years, 3 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, ricow1, vm-dev_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Report hint on unmatched show and hide combinators. BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/ecb1e33a7fb0f30842bdcbe76830cff6df0d91b9

Patch Set 1 #

Patch Set 2 : Remove line-ending changes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -82 lines) Patch
M pkg/compiler/lib/src/common.dart View 2 chunks +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/scalar_replacement.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 3 chunks +37 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 5 chunks +55 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/scanner/string_scanner.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 chunk +1 line, -4 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/interceptors.dart View 2 chunks +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/internal_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/isolate_patch.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 3 chunks +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/js_mirrors.dart View 2 chunks +1 line, -8 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/native_typed_data.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/js_runtime/lib/typed_data_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/async/async.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dart2js/web_audio_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_audio/dartium/web_audio_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_gl/dart2js/web_gl_dart2js.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M sdk/lib/web_gl/dartium/web_gl_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dart2js/web_sql_dart2js.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/web_sql/dartium/web_sql_dartium.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/html_dart2js.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/indexed_db_dart2js.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/svg_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_audio_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dart2js/web_gl_dart2js.darttemplate View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/dom/templates/html/dart2js/web_sql_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/html_dartium.darttemplate View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/svg_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_audio_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_gl_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/dartium/web_sql_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
Main changes in library_loader.dart and messages.dart. The rest are fixes of found problems.
5 years, 3 months ago (2015-09-16 12:56:51 UTC) #2
karlklose
LGTM.
5 years, 3 months ago (2015-09-17 09:51:00 UTC) #3
Johnni Winther
5 years, 3 months ago (2015-09-17 10:33:26 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ecb1e33a7fb0f30842bdcbe76830cff6df0d91b9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698